Only enforce open boundary mass conservation for open boundaries#4674
Merged
Only enforce open boundary mass conservation for open boundaries#4674
Conversation
navidcy
added
performance 🏍️
tomchor
approved these changes
Jul 26, 2025
Member
|
An additional point we discussed was to use tuples instead of arrays to hold the list of open boundaries. |
Member
Author
|
You can't might require a bit of rethinking/refactoring. |
Member
We just need to convert the arrays to tuples |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following from #4627, I noticed that
enforce_open_boundary_mass_conservation!was always called and doing stuff even when there was no open boundaries.This PR deals with that.
with @glwagner